Skip to content

fix: Making Event Name mandatory for publishing of event #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix: Making Event Name mandatory for publishing of event #6203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9822bb1
Event Name is mandatory
kushthedude Jul 16, 2019
61fb1ff
Merge branch 'development' into 3
kushthedude Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/api/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ def validate_event(user, modules, data):
raise ConflictException({'pointer': '/data/attributes/location-name'},
"Online Event does not have any locaton")

if not data.get('name', None) and data.get('state', None) == 'published':
Copy link
Member

@iamareebjamal iamareebjamal Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not data.get('name', None)?

Copy link
Member Author

@kushthedude kushthedude Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because event name should not be empty

raise ConflictException({'pointer': '/data/attributes/location-name'},
"Event Name is required to publish the event")

if data.get('searchable_location_name') and data.get('is_event_online'):
raise ConflictException({'pointer': '/data/attributes/searchable-location-name'},
"Online Event does not have any locaton")
Expand Down