Skip to content

fix: Make discount code & access code API URLs follow json api conventions #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: Make discount code & access code API URLs follow json api conventions #6238

merged 1 commit into from
Jul 26, 2019

Conversation

@abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Jul 26, 2019 •
edited
Loading

Fixes #6239

@auto-label auto-label bot added the fix label Jul 26, 2019
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #6238 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6238      +/-   ##
===============================================
+ Coverage        65.71%   65.74%   +0.02%     
===============================================
  Files              286      286              
  Lines            14523    14523              
===============================================
+ Hits              9544     9548       +4     
+ Misses            4979     4975       -4
Impacted Files Coverage Δ
app/api/__init__.py 100% <ø> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 24.6% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed4363...5e79103. Read the comment docs.

prateekj117
prateekj117 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iamareebjamal iamareebjamal merged commit ec24c30 into fossasia:development Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@prateekj117 prateekj117 prateekj117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make discount code & access code URL follow json api conventions

3 participants

@abhinavk96 @iamareebjamal @prateekj117