Skip to content

fix: Make discount code & access code API URLs follow json api conventions #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: Make discount code & access code API URLs follow json api conventions #6238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
'/tickets/<int:ticket_id>/discount-codes')
api.route(DiscountCodeDetail, 'discount_code_detail', '/discount-codes/<int:id>',
'/events/<int:event_id>/discount-code', '/event-invoices/<int:event_invoice_id>/discount-code',
'/event/<int:discount_event_id>/discount-code/<code>')
'/events/<int:discount_event_id>/discount-codes/<code>')
api.route(DiscountCodeRelationshipRequired, 'discount_code_event',
'/discount-codes/<int:id>/relationships/event')
api.route(DiscountCodeRelationshipOptional, 'discount_code_events',
Expand Down Expand Up @@ -542,7 +542,7 @@
'/events/<event_identifier>/access-codes', '/users/<int:user_id>/access-codes',
'/tickets/<int:ticket_id>/access-codes')
api.route(AccessCodeDetail, 'access_code_detail', '/access-codes/<int:id>',
'/event/<int:access_event_id>/access-code/<code>')
'/events/<int:access_event_id>/access-codes/<code>')
api.route(AccessCodeRelationshipRequired, 'access_code_event',
'/access-codes/<int:id>/relationships/event')
api.route(AccessCodeRelationshipOptional, 'access_code_user',
Expand Down
4 changes: 2 additions & 2 deletions docs/api/api_blueprint.apib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17815,7 +17815,7 @@ Delete a single discount code (Check permission to delete).
}
}

## Get Discount Code Detail using the code [/v1/event/{event_id}/discount-code/{code}]
## Get Discount Code Detail using the code [/v1/events/{event_id}/discount-codes/{code}]
+ Parameters
+ code: DC101 (string) - code associated with a discount code. (DC101 is an example of code)
+ event_id: 1 (integer) - ID of the Event in the form of an integer
Expand Down Expand Up @@ -18429,7 +18429,7 @@ Delete a single Access code.
}
}

## Access Code Detail using the Code [/v1/event/{event_id}/access-code/{code}]
## Access Code Detail using the Code [/v1/events/{event_id}/access-codes/{code}]
+ Parameters
+ code: AC101 (string) - code of the access-code.
+ event_id: 1 (integer) - ID of the Event in the form of an integer.
Expand Down
4 changes: 2 additions & 2 deletions tests/hook_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2804,7 +2804,7 @@ def discount_delete(transaction):
@hooks.before("Discount Codes > Get Discount Code Detail using the code > Get Discount Code Detail")
def discount_code_get_detail_using_code(transaction):
"""
GET event/1/discount-codes/DC101
GET events/1/discount-codes/DC101
:param transaction:
:return:
"""
Expand Down Expand Up @@ -2941,7 +2941,7 @@ def access_code_delete(transaction):
@hooks.before("Access Codes > Access Code Detail using the Code > Access Code Detail")
def access_code_get_detail_using_code(transaction):
"""
GET event/1/access-code/AC101
GET events/1/access-codes/AC101
:param transaction:
:return:
"""
Expand Down