Skip to content

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 8, 2019

Fixes #6330

Screenshot 2019-08-08 at 11 24 18 AM

Short description of what this resolves:

This fixes the attachments issue with order mails
The file path had to be fixed to move forward

Changes proposed in this pull request:

  • Changed storage paths to fix order emails

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 8, 2019
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #6331 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6331   +/-   ##
============================================
  Coverage        65.26%   65.26%           
============================================
  Files              287      287           
  Lines            14713    14713           
============================================
  Hits              9602     9602           
  Misses            5111     5111
Impacted Files Coverage Δ
app/api/helpers/order.py 40.9% <ø> (ø) ⬆️
app/api/orders.py 28.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390b56...5659691. Read the comment docs.

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe 3rd PR solving the same issue

@iamareebjamal iamareebjamal merged commit b98471f into fossasia:development Aug 8, 2019
mrsaicharan1 added a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attachments showing up as not found

3 participants