Skip to content

Conversation

@nnhathung
Copy link
Contributor

Fixes #9047

Short description of what this resolves:

  • Unable to receive pdf from [/v1/badge-forms/print-badge-pdf]

Changes proposed in this pull request:

  • retrieve data correctly for object

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@nnhathung nnhathung marked this pull request as ready for review August 7, 2023 16:09
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing. Thanks

@mariobehling mariobehling merged commit 28d53c4 into fossasia:development Aug 8, 2023
@nnhathung
Copy link
Contributor Author

Badge.postman_collection.zip
@cweitat @shaunBoahCodes: collection for get field identifier and print badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to receive pdf from [/v1/badge-forms/print-badge-pdf]

3 participants