Skip to content

Conversation

@CloudyPadmal
Copy link
Collaborator

Fixes #1317

Changes:

  • Replaced org.fossasia.pslab with org.pslab

Screenshot/s for the changes:

Not available

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

Not available

@CloudyPadmal CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Aug 2, 2018
@CloudyPadmal CloudyPadmal self-assigned this Aug 2, 2018
@CloudyPadmal
Copy link
Collaborator Author

Thank you @asitava1998 :)

@Avjeet
Copy link
Contributor

Avjeet commented Aug 2, 2018

@CloudyPadmal Could you replace one image having a dialog box with a screenshot showing bottom sheet in this PR only.

@CloudyPadmal
Copy link
Collaborator Author

@Avjeet please refer to the issue this PR is resolving.

@CloudyPadmal CloudyPadmal merged commit fdff6d0 into fossasia:development Aug 3, 2018
@CloudyPadmal CloudyPadmal deleted the updateReadme branch August 3, 2018 11:18
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Aug 3, 2018
@CloudyPadmal
Copy link
Collaborator Author

Thank you @Avjeet ! 👍

neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants