refactor: update screenshots #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
added
the
Status: Review Required
Contributor
|
@CloudyPadmal Please update the Lux Meter, Accelerometer and Compass Instruments screenshots too. |
Collaborator
Author
|
@harsh-2711 these readme screenshots are to show just a preview. No need to show every single screen. |
Contributor
|
@CloudyPadmal But I think we can update Lux Meter screenshot as the one shown in the current screenshot isn't correct as the data lines aren't smooth and also it doesn't contain the new functionality of menu in the toolbar. Rest looks good to me. |
Collaborator
Author
|
Ahh yes the menu bar is missing. Shall we put the one in your PR as the current one has a floppy disk icon? |
CloudyPadmal
force-pushed
the
updatescreens
branch
from
e4fb222 to
d537e97
Compare
Collaborator
Author
|
Screenshot of Luxmeter was updated |
cweitat
approved these changes
Aug 8, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
refactor: update screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1325
Changes:
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: