Skip to content

feat: Added SensorGraphViewActivity to visualize and export data in CSV format #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2018
Merged

feat: Added SensorGraphViewActivity to visualize and export data in CSV format #1347

merged 2 commits into from
Aug 11, 2018

Conversation

@Avjeet
Copy link
Contributor

@Avjeet Avjeet commented Aug 9, 2018 •
edited
Loading

Fixes #1346
Fixes #1322
Fixes #1316
Fixes #1323

Changes:

Added SensorGraphViewActivity including features:

  • Show graph of recorded data, time and date of recording and Map showing the location
  • menu item to simulate the graph and to save the data into the CSV file.Stored the lux sensor data in

Other changes

  • Realm database in LuxData.class model instead of CSV file.
  • Added lux data records in form of card items with delete option in newly created DataLogger Activity.
  • Added Logged Data in navigation panel that opens DataLoggerActivity
  • Prevented the unnecessary repetition of data by removing for loop
  • Created option to open DataLoggerActivity from lux meter menu.(As discussed in previous meeting)

Screenshot/s for the changes:
UI of Activity

CSV file saved[Updated]
image

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
graph.zip

@mariobehling
Copy link
Member

mariobehling commented Aug 9, 2018

Thanks. Please change:

  • date to 09 Aug 2018
  • add column with exact time of start of recording
  • add column with exact time of end of recording
  • add Timezone
  • add Android device information columns e.g. name of device, brand/version of device, Android version

@abhinavraj23 abhinavraj23 removed the request for review from CloudyPadmal August 9, 2018 07:03
@Avjeet
Copy link
Contributor Author

Avjeet commented Aug 9, 2018 •
edited
Loading

@mariobehling @cweitat Added the info in CSV file. Updated the screenshot

@cweitat
Copy link
Contributor

cweitat commented Aug 9, 2018

@Avjeet hi, what Mario meant was to add a column name "Start Time" and "End Time" with the exact time as data, not "exact time of end of recording" as column name. Date is not changed. And Timezone, without capital Z

@Avjeet
Copy link
Contributor Author

Avjeet commented Aug 10, 2018

@cweitat I have made all the changes see the screenshot please merge PR #1305 so that I generate apk with updated icons.

@cweitat
Copy link
Contributor

cweitat commented Aug 11, 2018

@Avjeet fix codacy thanks

@Avjeet Avjeet force-pushed the Avi_graphe branch 2 times, most recently from 427e4f9 to 218274e Compare August 11, 2018 17:45
@Avjeet
added SensorGraphViewActivity to visualize sensor recorded data
ae06d5f 
added more info in CSV file

resolved location issue

some minor change

codacy fix
@Avjeet
Copy link
Contributor Author

Avjeet commented Aug 11, 2018

@cweitat fixed codacy

@cweitat cweitat merged commit 016bcea into fossasia:development Aug 11, 2018
This was referenced Aug 12, 2018
Closed
Closed
Closed
Closed
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
@cweitat
Merge pull request fossasia#1347 from Avjeet/Avi_graphe
1d8ff4b 
feat: Added SensorGraphViewActivity to visualize and export data in CSV format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cweitat cweitat cweitat approved these changes

@harsh-2711 harsh-2711 Awaiting requested review from harsh-2711

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

@Vikum94 Vikum94 Awaiting requested review from Vikum94

@abhinavraj23 abhinavraj23 Awaiting requested review from abhinavraj23

Assignees

@Avjeet Avjeet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Avjeet @mariobehling @cweitat