feat: stored data in Realm database and added logged data option in navigation panel #1323

Avjeet · 2018-08-02T22:46:59Z

Fixes #1322 #1316
Fixes #1321

Changes:

Stored the lux sensor data in Realm database in LuxData.class model instead of CSV file.
Added lux data records in form of card items with delete option in newly created DataLogger Activity.
Added Logged Data in navigation panel that opens DataLoggerActivity
Prevented the unnecessary repetition of data by removing for loop
Created option to open DataLoggerActivity from lux meter menu.(As discussed in previous meeting)

To do: Show the data in Logged Data Activity in form of graph instead of the list.

Screenshot/s for the changes
Below GIF shows the complete workflow[Updated - 11/08/2018]

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
I have reformatted code in every file included in this PR [CTRL+ALT+L]
My code does not contain any extra lines or extra spaces
I have requested reviews from other members

APK for testing: realm.zip

CloudyPadmal · 2018-08-03T01:43:54Z

@Avjeet in the recent meeting there was a format suggested. Can you please implement that? Also please fix one issue in one PR. It's one of the best practices we have to follow.

Avjeet · 2018-08-03T22:31:45Z

@CloudyPadmal Actually all these issues are linked in some way so for proper resolution of all of them I had to make one PR,

Avjeet · 2018-08-03T22:57:01Z

@CloudyPadmal I have updated the screenshot

CloudyPadmal · 2018-08-04T00:23:35Z

Ah now it looks good! 👍

CloudyPadmal · 2018-08-04T00:24:07Z

app/src/main/java/org/pslab/activity/LuxDataAdapter.java

+import io.realm.RealmResults;
+
+/**
+ * Created by Your name on 03-08-2018.


Shall we remove this?

CloudyPadmal · 2018-08-04T00:24:47Z

app/src/main/java/org/pslab/activity/LuxDataAdapter.java

+/**
+ * Created by Your name on 03-08-2018.
+ */
+class LuxDataAdapter extends RecyclerView.Adapter<LuxDataAdapter.ViewHolder> {


Is it possible to create a generic adapter for every instrument?

CloudyPadmal · 2018-08-04T00:25:16Z

app/src/main/java/org/pslab/activity/LuxDataAdapter.java

+            @Override
+            public void onClick(View view) {
+                RealmResults<LuxData> results = realm.where(LuxData.class).equalTo("foreignKey",temp.getUniqueRef()).findAll();
+                Log.i("realmResult",String.valueOf(results.size()));


Once you have finalized this PR, please remove this..

CloudyPadmal · 2018-08-04T00:26:21Z

app/src/main/java/org/pslab/fragment/LuxMeterFragmentData.java

+//                                                    })
+//                                                    .setNegativeButton(R.string.cancel, null)
+//                                                    .create()
+//                                                    .show();


I guess these comments are in WIP right?

Avjeet · 2018-08-04T23:10:38Z

@CloudyPadmal I have removed the CSV saving part, for now, I will implement it in Logged Data Activity later.

CloudyPadmal · 2018-08-05T02:42:58Z

app/src/main/java/org/pslab/activity/SensorLoggerListAdapter.java

+import io.realm.RealmResults;
+
+/**
+ * Created by Your name on 03-08-2018.


Either change this to Avjeet or delete this template block

CloudyPadmal · 2018-08-05T02:43:27Z

app/src/main/java/org/pslab/activity/ShowLoggedData.java


 /**
 * Created by viveksb007 on 12/8/17.
+ * deprecated


If this file is no needed, we can delete it right?

CloudyPadmal · 2018-08-05T02:43:52Z

app/src/main/java/org/pslab/models/LuxData.java

+
+
+/**
+ * Created by Your name on 31-07-2018.


Same here, template

CloudyPadmal · 2018-08-05T02:44:40Z

app/src/main/res/layout/logger_data_item.xml

+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_marginBottom="5dp"
+                android:text="Lux Meter"


I guess these are dummy texts right?

Avjeet · 2018-08-07T10:29:58Z

@CloudyPadmal @harsh-2711 @abhinavraj23 I have updated this PR as discussed in meeting and uploaded the apk file, plz review it asap.
I will make the changes regarding setting part in next PR.

cweitat · 2018-08-07T15:58:08Z

@Avjeet conflicts pls solve

Avjeet · 2018-08-10T19:57:22Z

@CloudyPadmal @harsh-2711 @abhinavraj23 I have rebased the code with new icons pls review this

some minor changes resolved conflicts

Avjeet · 2018-08-12T10:43:02Z

merged with #1347

CloudyPadmal assigned Avjeet Aug 3, 2018

CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Aug 3, 2018

Avjeet added the In Progress Developer is working on the problem label Aug 3, 2018

Avjeet force-pushed the Avi_realm branch from 5b76505 to 9312228 Compare August 3, 2018 22:56

CloudyPadmal requested changes Aug 4, 2018

View reviewed changes

CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Aug 4, 2018

Avjeet mentioned this pull request Aug 4, 2018

fix: Changed the UI and functionality of buttons in Lux Meter #1303

Closed

5 tasks

Avjeet force-pushed the Avi_realm branch from 9312228 to 9ba35aa Compare August 4, 2018 22:40

Avjeet removed the In Progress Developer is working on the problem label Aug 4, 2018

CloudyPadmal requested changes Aug 5, 2018

View reviewed changes

CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Aug 5, 2018

CloudyPadmal requested review from abhinavraj23 and harsh-2711 August 5, 2018 02:45

CloudyPadmal added the Status: Conflicts Merge conflicts blocking reviews and merges label Aug 7, 2018

Avjeet force-pushed the Avi_realm branch 2 times, most recently from ca9af48 to 4b9cf91 Compare August 7, 2018 10:16

Avjeet removed the Status: Conflicts Merge conflicts blocking reviews and merges label Aug 7, 2018

Avjeet mentioned this pull request Aug 8, 2018

feat: extended record button to start sensor data fetching and recording #1305

Merged

5 tasks

Avjeet force-pushed the Avi_realm branch 2 times, most recently from 9e01fb8 to 6223796 Compare August 8, 2018 13:35

Avjeet requested review from CloudyPadmal and cweitat August 8, 2018 13:40

cweitat approved these changes Aug 8, 2018

View reviewed changes

Avjeet force-pushed the Avi_realm branch 5 times, most recently from 7fc1c72 to abdfb25 Compare August 10, 2018 18:42

Avjeet mentioned this pull request Aug 10, 2018

feat: Added SensorGraphViewActivity to visualize and export data in CSV format #1347

Merged

5 tasks

Avjeet force-pushed the Avi_realm branch from abdfb25 to 9953c4f Compare August 11, 2018 05:29

stored data in realm database and added data logger activity

3ff8451

some minor changes resolved conflicts

Avjeet force-pushed the Avi_realm branch from 9953c4f to 3ff8451 Compare August 11, 2018 05:33

Avjeet closed this Aug 12, 2018

CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Dec 13, 2018

feat: stored data in Realm database and added logged data option in navigation panel #1323

feat: stored data in Realm database and added logged data option in navigation panel #1323

Uh oh!

Conversation

Avjeet commented Aug 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CloudyPadmal commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Avjeet commented Aug 3, 2018

Uh oh!

Avjeet commented Aug 3, 2018

Uh oh!

CloudyPadmal commented Aug 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Avjeet commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Avjeet commented Aug 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cweitat commented Aug 7, 2018

Uh oh!

Avjeet commented Aug 10, 2018

Uh oh!

Avjeet commented Aug 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Avjeet commented Aug 2, 2018 •

edited

Loading

CloudyPadmal commented Aug 3, 2018 •

edited

Loading

Avjeet commented Aug 4, 2018 •

edited

Loading

Avjeet commented Aug 7, 2018 •

edited

Loading