fix: solved issue of crashing in capacitance measurement #1379
Conversation
abhinavraj23
added
the
Status: Review Required
abhinavraj23
changed the title
|
Tested and it is still not working as intended. |
|
@cweitat That is correct, if you would have done it previously the app would have crashed, but now it's showing cannot measure. This problems occurs when there is a problem in data fetching, at this point of time the user has reconnect the otg cable to the device, shall I put the toast message for the same? |
|
@abhinavraj23 Theoretically, if the multimeter is set to constant reading then this problem would have been eliminated. Probably at a refresh rate of 1 second or faster. And a hold function to replace read button. Anyway will try the apk soon and feedback. Thanks |
|
@cweitat Sure I will make those change, but for now we need to solve the issue of crashing, that is what this PR is for. I will implement the auto-read feature in my subsequent PRs 👍 |
|
@abhinavraj23 yup. got your point. Thanks :) |
|
@cweitat @CloudyPadmal @harsh-2711 @Avjeet Please review it 👍 |
|
Not crashing anymore |
CloudyPadmal
removed
the
Status: Review Required
3 participants
Fixes #1376
Changes:
There was an infinity loop in capacitance measurement, changed it to a finite loop, also handled null capacitance value in MultimeterActivity
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]capacitance.apk.zip