fix: resolved empty data bug in lux meter #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Oct 1, 2018
| editor.putLong("uniqueCount", uniqueRef + 1); | ||
| editor.commit(); | ||
| }else{ | ||
| CustomSnackBar.showSnackBar(coordinatorLayout, "No Data Fetched", null, null); |
Collaborator
There was a problem hiding this comment.
Please add this text to strings.xml and fetch from there
| SharedPreferences.Editor editor = realmPreferences.edit(); | ||
| editor.putLong("uniqueCount", uniqueRef + 1); | ||
| editor.commit(); | ||
| if(selectedFragment.saveDataInRealm(uniqueRef, locationPref, gpsLogger)){ |
Collaborator
There was a problem hiding this comment.
Give this code a reformat
| realm.beginTransaction(); | ||
|
|
||
| SensorLogged sensorLogged = realm.createObject(SensorLogged.class, uniqueRef); | ||
| sensorLogged.setSensor("Lux Meter"); |
|
|
||
| if (includeLocation && gpsLogger != null) { | ||
| Location location = gpsLogger.getBestLocation(); | ||
| if (location != null) { |
Collaborator
There was a problem hiding this comment.
Can we check location null in the 414 if block and reduce this?
Contributor
Author
There was a problem hiding this comment.
I tried that but then I had to do this to prevent some null pointer exceptions.
CloudyPadmal
added
the
Status: Review Required
some minor chages
Avjeet
force-pushed
the
Avi_remSetting
branch
from
38ce7ac to
b77d8e5
Compare
Avjeet
added
Status: Review Required
abhinavraj23
approved these changes
Oct 21, 2018
CloudyPadmal
approved these changes
Oct 21, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
some minor chages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1400
Changes:
Added if-else in lux meter fragment to check for empty data before storing in the realm database in the form of record.
Screenshot/s for the changes:Not a UI change
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
emptyfix.zip