fix: Hard Coded dimensions fixed in splash screen #1406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-2711
requested review from
Avjeet,
CloudyPadmal,
abhinavraj23 and
harsh-2711
harsh-2711
changed the title
CloudyPadmal
approved these changes
Oct 5, 2018
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
Thank you for the PR @imrajat7 ! 👍
harsh-2711
approved these changes
Oct 6, 2018
Contributor
harsh-2711
left a comment
harsh-2711
left a comment
There was a problem hiding this comment.
Thanks for PR @imrajat7 But from next time, please don't add dimensions at the end of the file.
Member
Author
|
Thanks. I will definitely act upon your advice.
…On Sun 7 Oct, 2018, 1:03 AM Harsh Patel, ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for PR @imrajat7 <https://github.com/imrajat7> But from next time,
please don't add dimensions at the end of the file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1406 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoN1yUEkuIoyyHeC8qXyZV67hsU2RVrlks5uiQWZgaJpZM4XIqGn>
.
|
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1395
Changes: Hard Coded Dimensions removed from the splash screen xml file.
Screenshot/s for the changes: NA
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-debug.zip