Skip to content

feat: abstract class for PSLab Sensors #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2018
Merged

feat: abstract class for PSLab Sensors #1418

merged 1 commit into from
Oct 27, 2018

Conversation

@CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Oct 21, 2018 •
edited
Loading

Fixes #1417

Changes:

  • Added an abstract class containing all the common functions a sensor should implement

Screenshot/s for the changes:

Not available

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

Not available

PS:
I am implementing the LuxMeter with this abstract class and will make a PR soon with the changes

@CloudyPadmal CloudyPadmal self-assigned this Oct 21, 2018
@CloudyPadmal CloudyPadmal added Enhancement Improvement to an existing feature Status: Review Required Requested reviews from peers and maintainers labels Oct 21, 2018
@mariobehling mariobehling merged commit 7c283c8 into fossasia:development Oct 27, 2018
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Dec 13, 2018
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
@CloudyPadmal @mariobehling
feat: abstract class for PSLab Sensors (fossasia#1418)
ddda00f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cweitat cweitat cweitat approved these changes

@woshikie woshikie Awaiting requested review from woshikie

@asitava1998 asitava1998 Awaiting requested review from asitava1998

@Avjeet Avjeet Awaiting requested review from Avjeet

@harsh-2711 harsh-2711 Awaiting requested review from harsh-2711

@abhinavraj23 abhinavraj23 Awaiting requested review from abhinavraj23

@yatri1609 yatri1609 Awaiting requested review from yatri1609

Assignees

@CloudyPadmal CloudyPadmal

Labels

Enhancement Improvement to an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CloudyPadmal @cweitat @mariobehling