fix: improved lux meter with features #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
added
Enhancement
CloudyPadmal
requested review from
Avjeet,
abhinavraj23,
akarshan96,
asitava1998,
cweitat and
harsh-2711
Collaborator
Author
|
Please test the APK and update here on what needs to be fixed and changed. Thanks! :) |
Contributor
|
@CloudyPadmal In the first screenshot that you uploaded, the main reading of the gauge is overlapping with the meter readings. So can we do something about it? |
cweitat
approved these changes
Nov 3, 2018
cweitat
requested changes
Nov 3, 2018
Contributor
cweitat
left a comment
cweitat
left a comment
There was a problem hiding this comment.
It starts automatically collecting data when instrument is opened. App crashes when press record. Android 8.0
Collaborator
Author
|
@harsh-2711 yes good point. I'll see if I can make an offset. @cweitat yes there was a location permission error. I've fixed that. Will update this one soon. |
CloudyPadmal
force-pushed
the
LuxSensor
branch
2 times, most recently
from
85671a0 to
4fbd411
Compare
Collaborator
Author
|
@cweitat @harsh-2711 I've updated the PR with changes. |
CloudyPadmal
force-pushed
the
LuxSensor
branch
from
4fbd411 to
41ccf9d
Compare
CloudyPadmal
force-pushed
the
LuxSensor
branch
5 times, most recently
from
c6e0658 to
6095cde
Compare
Collaborator
Author
|
I've completely fixed the issue #1427 and the apk is the current one. Please have a look. |
cweitat
approved these changes
Nov 7, 2018
Contributor
|
@CloudyPadmal have a look at codacy |
CloudyPadmal
force-pushed
the
LuxSensor
branch
2 times, most recently
from
703594c to
c2ecf2b
Compare
dimensions permissions added marker classes added markers added logging support added new logo added new logo and completed logging updated logging codacy codacy
CloudyPadmal
force-pushed
the
LuxSensor
branch
from
c2ecf2b to
2b46a8e
Compare
mariobehling
approved these changes
Nov 15, 2018
CloudyPadmal
removed
the
Status: Review Required
Princejhabak
pushed a commit
to Princejhabak/pslab-android
that referenced
this pull request
Dec 8, 2018
dimensions permissions added marker classes added markers added logging support added new logo added new logo and completed logging updated logging codacy codacy
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
dimensions permissions added marker classes added markers added logging support added new logo added new logo and completed logging updated logging codacy codacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1427
Changes:
In this PR, I have created an abstract sensor class
PSLabSensorwhich holds all the necessary functions and templates needed by each sensor. Lux Meter can be taken as an example to design other sensors to have a uniform layout and a theme.Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
NewLuxMeter.apk.zip