Skip to content

Conversation

@CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Dec 15, 2018

Fixes #1480

Changes:

  • Added steps to follow how to squash all commits into one to follow our best code practices.

Screenshot/s for the changes:

Not applicable

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

Not applicable

@CloudyPadmal CloudyPadmal added Status: Review Required Requested reviews from peers and maintainers Documentation Non-code related documentation tasks labels Dec 15, 2018
@CloudyPadmal CloudyPadmal self-assigned this Dec 15, 2018
docs: updated readme with squash tips

docs: updated readme with squash tips
@CloudyPadmal CloudyPadmal merged commit 327570f into fossasia:development Dec 15, 2018
@CloudyPadmal CloudyPadmal deleted the contribGuidelines branch December 15, 2018 18:23
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Dec 15, 2018
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
docs: updated readme with squash tips

docs: updated readme with squash tips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Non-code related documentation tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants