-
Notifications
You must be signed in to change notification settings - Fork 264
updated Readme and Handled Typeerror on query-server #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Readme.md has been updated with the latest trends. It did not have the `&num=10` mentioned before. query-server now returns a errorObject in JSON Format whenever 500 error_code is encountered, so that the page is not left stuck. Fixes https://github.com/fossasia/query-server#142 and https://github.com/fossasia/query-server#140
|
Shouldn't we put some efforts to actually fetch the result, why we get the error code 500 at the first step? This looks like a workaround to me. |
|
@AnshulMalik you are very right. |
|
@gabru-md Ok. But I am pretty sure google isn't returning 500 response. It's caused by |
|
@AnshulMalik is your PR solving this problem ? |
|
Yes @gabru-md, it does. Meanwhile, I am trying to generate a demo link. |
|
But then it is not generating the required number of results or is it ? |
|
@AnshulMalik I believe that your PR is not a fix to the pertaining problem. Since it is defying the very purpose of |
|
Ok, let's iterate from here. Cheers. |
PDF/ZIP made with optional background
Readme.md has been updated with the latest trends. It did not have the
&num=10mentioned before.query-server now returns a errorObject in JSON Format whenever 500 error_code is encountered, so that the page is not left stuck.
Fixes #142 and #140
Image for corresponding change:
