-
Notifications
You must be signed in to change notification settings - Fork 263
Added Youtube support #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dd28e51
Initial commit for Youtube support
bhaveshAn b0f3fe2
Merge branch 'master' into bhavesh-youtube
bhaveshAn 5fadb73
Merge branch 'master' into bhavesh-youtube
bhaveshAn 91764b0
Merge branch 'master' into bhavesh-youtube
bhaveshAn f17b724
Merge branch 'master' into bhavesh-youtube
bhaveshAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from __future__ import print_function | ||
| from generalized import Scraper | ||
|
|
||
|
|
||
| class Youtube(Scraper): | ||
| """Scraper class for Youtube""" | ||
|
|
||
| def __init__(self): | ||
| self.url = 'https://www.youtube.com/results' | ||
| self.queryKey = 'search_query' | ||
|
|
||
| def parseResponse(self, soup): | ||
| """ Parse the response and return list of urls | ||
| Returns: urls (list) | ||
| [[Tile1,url1], [Title2, url2],..] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The returned values are not urls. They are dicts. I know these changes were not tested under Python 3. |
||
| """ | ||
| urls = [] | ||
| for a in soup.findAll('a'): | ||
| if a.get('href').startswith('/watch?'): | ||
| link = 'https://www.youtube.com' + str(a.get('href')) | ||
| if not a.getText().startswith('\n\n'): | ||
| urls.append({'title': a.getText(), 'link': link}) | ||
| else: | ||
| continue | ||
|
|
||
| print('Youtube parsed: ' + str(urls)) | ||
|
|
||
| return urls | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this logic in two different files can be the source of future bugs. Please encapsulate this logic in one file or the other but not in both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cclauss Please review again