Skip to content

Added Mojeek support #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bhaveshAn wants to merge 1 commit into from
Closed

Added Mojeek support #296

bhaveshAn wants to merge 1 commit into from

Conversation

@bhaveshAn
Copy link
Member

@bhaveshAn bhaveshAn commented Oct 29, 2017

Fixes #295

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Added Mojeek support (A UK based search engine)

@gabru-md @vaibhavsingh97 @shashank-sharma Please review.
Providing the heroku deployment at https://intense-plateau-86110.herokuapp.com/
Thanks !!

@ghost ghost added the needs-review label Oct 29, 2017
@ghost ghost assigned bhaveshAn Oct 29, 2017
@vaibhavsingh97
Copy link
Member

vaibhavsingh97 commented Oct 29, 2017

@bhaveshAn Do we really need these?

@bhaveshAn
Copy link
Member Author

bhaveshAn commented Oct 29, 2017 •
edited
Loading

Any search engine which is not a meta search engine or which doesn't depends on some other search engine for getting the results can be added in this project.
And this could be added since EXALEAD is a france based search engine and this one is UK based.

@ghost
Copy link

ghost commented Oct 30, 2017

Hi @bhaveshAn!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@gabru-md
Copy link
Member

gabru-md commented Oct 30, 2017

@bhaveshAn I definitely agree with @vaibhavsingh97 .
Do we really need so many of these ?
@mariobehling can you please comment on this ? So that we can know

@bhaveshAn
Copy link
Member Author

bhaveshAn commented Oct 30, 2017

@mariobehling @niranjan94 Please review

@ghost
Copy link

ghost commented Nov 2, 2017

Hi @bhaveshAn!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

1 similar comment
@ghost
Copy link

ghost commented Nov 2, 2017

Hi @bhaveshAn!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@ghost
Copy link

ghost commented Nov 2, 2017

Hi @bhaveshAn!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@bhaveshAn bhaveshAn closed this Nov 5, 2017
@ghost ghost added invalid and removed needs-review labels Nov 5, 2017
@bhaveshAn bhaveshAn reopened this Nov 5, 2017
@bhaveshAn bhaveshAn closed this Nov 5, 2017
@bhaveshAn bhaveshAn deleted the bhavesh-mojeek branch November 5, 2017 15:14
Remorax pushed a commit to Remorax/query-server that referenced this pull request Jan 14, 2018
@jajodiaraghav @S2606
Selecting a default background without uploading CSV shows error (fos…
450caee 
…sasia#296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bhaveshAn bhaveshAn

Labels

invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Mojeek support

3 participants

@bhaveshAn @vaibhavsingh97 @gabru-md