Skip to content

Conversation

@starlord1311
Copy link
Contributor

@starlord1311 starlord1311 commented Nov 1, 2017

Fixes #299

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

-made changes in the index.html for syntax highlighting

@ghost ghost added the needs-review label Nov 1, 2017
@ghost ghost assigned starlord1311 Nov 1, 2017
@ParthS007
Copy link
Member

@starlord1311 please add a screenshot of the changes

@starlord1311
Copy link
Contributor Author

@ParthS007 ss of the changes i made in the code right?

@starlord1311
Copy link
Contributor Author

sorry didnt get your question prperly @ParthS007

@ParthS007
Copy link
Member

ParthS007 commented Nov 1, 2017

I mean to say that after doing changes , take the screenshot which shows changes done by you and attach it above.

@starlord1311
Copy link
Contributor Author

screenshot 8

@starlord1311
Copy link
Contributor Author

@ParthS007 is this what you meant?

@vaibhavsingh97
Copy link
Member

@starlord1311 After you made changes, We want you to run locally and see the changes made by is the expected output. If yes, then took screenshot and while making a PR add screenshot 👍

@niranjan94
Copy link
Member

@starlord1311 also provide a test deployment on heroku please. We need to make it a point to do this for all PRs.

@vaibhavsingh97
Copy link
Member

@niranjan94 What about automatic heroku deployment with each PR?

@niranjan94
Copy link
Member

niranjan94 commented Nov 2, 2017

@vaibhavsingh97 Heroku pipeline (which can be used for auto deployments) works properly only if all branches exist on this repository itself. Not when the branches are from cloned repos.

And its not hard for contributors to do a heroku deployment. So, its upto the contributors to provide deployments for each PR.

@starlord1311
Copy link
Contributor Author

@vaibhavsingh97 how to run it locally?

@starlord1311
Copy link
Contributor Author

screenshot 11
this is what is coming when i open the index.html

@bhaveshAn
Copy link
Member

@starlord1311 Please go through the Local installation of this project. And then run it python app/server.py

@bhaveshAn
Copy link
Member

Any update ??

@starlord1311
Copy link
Contributor Author

@bhaveshAn i am still not able to run it loally idk why

@bhaveshAn
Copy link
Member

Then how are you making the PRs ??
Please don't make untested PRs.

i am still not able to run it loally idk why

goto http://localhost:7001/ and tell the status ??

@starlord1311
Copy link
Contributor Author

screenshot 19

@starlord1311
Copy link
Contributor Author

is this fine?

@starlord1311
Copy link
Contributor Author

@bhaveshAn ^

@vaibhavsingh97
Copy link
Member

@starlord1311 Can you please post the screenshot of the output.

@starlord1311
Copy link
Contributor Author

screenshot 22

@starlord1311
Copy link
Contributor Author

@vaibhavsingh97 pic of the output

@mariobehling
Copy link
Member

Ok, thanks.

@mariobehling mariobehling merged commit 388b83d into fossasia:master Dec 7, 2017
@ghost ghost added ready-to-ship and removed needs-review labels Dec 7, 2017
@bhaveshAn bhaveshAn mentioned this pull request Dec 7, 2017
2 tasks
@AnshulMalik
Copy link
Contributor

AnshulMalik commented Dec 7, 2017

@mariobehling No one approved this PR, it was a WIP

Remorax pushed a commit to Remorax/query-server that referenced this pull request Jan 14, 2018
Fixed some typos and errors in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants