-
Notifications
You must be signed in to change notification settings - Fork 264
syntax highlighting for json response #52 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@starlord1311 please add a screenshot of the changes |
|
@ParthS007 ss of the changes i made in the code right? |
|
sorry didnt get your question prperly @ParthS007 |
|
I mean to say that after doing changes , take the screenshot which shows changes done by you and attach it above. |
|
@ParthS007 is this what you meant? |
|
@starlord1311 After you made changes, We want you to run locally and see the changes made by is the expected output. If yes, then took screenshot and while making a PR add screenshot 👍 |
|
@starlord1311 also provide a test deployment on heroku please. We need to make it a point to do this for all PRs. |
|
@niranjan94 What about automatic heroku deployment with each PR? |
|
@vaibhavsingh97 Heroku pipeline (which can be used for auto deployments) works properly only if all branches exist on this repository itself. Not when the branches are from cloned repos. And its not hard for contributors to do a heroku deployment. So, its upto the contributors to provide deployments for each PR. |
|
@vaibhavsingh97 how to run it locally? |
|
@starlord1311 Please go through the Local installation of this project. And then run it |
|
Any update ?? |
|
@bhaveshAn i am still not able to run it loally idk why |
|
Then how are you making the PRs ??
goto |
|
is this fine? |
|
@starlord1311 Can you please post the screenshot of the output. |
|
@vaibhavsingh97 pic of the output |
|
Ok, thanks. |
|
@mariobehling No one approved this PR, it was a WIP |
Fixed some typos and errors in README.md




Fixes #299
Checklist
masterbranch.Changes proposed in this pull request:
-made changes in the index.html for syntax highlighting