Skip to content

Conversation

@bhaveshAn
Copy link
Member

Fixes #295

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

@ParthS007 @rupav @AnshulMalik Please review !!
Providing heroku deployment https://evening-plateau-77221.herokuapp.com/

@ghost ghost added the needs-review label Nov 5, 2017
@ghost ghost assigned bhaveshAn Nov 5, 2017
Copy link
Member

@ParthS007 ParthS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 It will be much better if the codacy issue is resolved .

@ghost ghost removed the needs-review label Nov 5, 2017
@ghost
Copy link

ghost commented Nov 7, 2017

Hi @bhaveshAn!

Looks like your PR has some conflicts. 😟
Could you resolve them and rebase on top of the latest upstream code ?

@bhaveshAn bhaveshAn closed this Nov 10, 2017
@ghost ghost added the invalid label Nov 10, 2017
@bhaveshAn bhaveshAn deleted the bhaveshAn-mojeek branch November 10, 2017 16:56
@bhaveshAn bhaveshAn restored the bhaveshAn-mojeek branch November 10, 2017 16:56
@bhaveshAn bhaveshAn deleted the bhaveshAn-mojeek branch November 10, 2017 16:58
@bhaveshAn bhaveshAn restored the bhaveshAn-mojeek branch November 10, 2017 16:58
@bhaveshAn bhaveshAn reopened this Nov 10, 2017
@bhaveshAn
Copy link
Member Author

@mariobehling Please review and see if it can be merged (A UK based search engine - Mojeek ). Providing heroku deployment at https://evening-plateau-77221.herokuapp.com/

@ghost
Copy link

ghost commented Nov 10, 2017

Hi @bhaveshAn!

Looks like your PR is behind the upstream
Could you rebase it on top of the latest upstream code ?

@cclauss
Copy link
Contributor

cclauss commented Nov 12, 2017

You can suppress the Codacy issue merely by decorating the function in question with either @classmethod or @staticmethod.

@mariobehling mariobehling merged commit 17282f4 into fossasia:master Nov 17, 2017
@ghost ghost added ready-to-ship and removed invalid labels Nov 17, 2017
@bhaveshAn bhaveshAn deleted the bhaveshAn-mojeek branch November 17, 2017 10:47
Remorax pushed a commit to Remorax/query-server that referenced this pull request Jan 14, 2018
Fixes fossasia#319

Signed-off-by: yashLadha <201551061@iiitvadodara.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Mojeek support

4 participants