Skip to content

Sort the result by file and exclude attributes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

Sort the result by file and exclude attributes #125

merged 1 commit into from
Jun 15, 2023

Conversation

@JustinWonjaePark
Copy link
Contributor

@JustinWonjaePark JustinWonjaePark commented Jun 14, 2023

Description

  • Sort the result by "Source Name or Path" and "Exclude" attributes.
  • Add a file in /tests/testsfiles/test/ to check if sorting works.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark added the chore [PR/Issue] Refactoring, maintenance the code label Jun 14, 2023
@JustinWonjaePark JustinWonjaePark self-assigned this Jun 14, 2023
@JustinWonjaePark JustinWonjaePark requested a review from soimkim June 14, 2023 01:23
@JustinWonjaePark JustinWonjaePark marked this pull request as draft June 14, 2023 01:24
@JustinWonjaePark JustinWonjaePark marked this pull request as ready for review June 15, 2023 06:24
@JustinWonjaePark JustinWonjaePark merged commit b5fa60c into main Jun 15, 2023
@JustinWonjaePark JustinWonjaePark deleted the dev_sorting branch June 15, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soimkim soimkim soimkim approved these changes

Assignees

@JustinWonjaePark JustinWonjaePark

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JustinWonjaePark @soimkim