Skip to content

Priority change between Download Location extraction and scanner operation #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 21, 2023
Merged

Priority change between Download Location extraction and scanner operation #133

merged 10 commits into from
Aug 21, 2023

Conversation

@JustinWonjaePark
Copy link
Contributor

@JustinWonjaePark JustinWonjaePark commented Aug 11, 2023 •
edited by soimkim
Loading

Description

Change download location extracting code ran independently from the scanners.

Now, download location with keyword "SPDX-PackageDownloadLocation" can be found
even if there are no scanner result for each source files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark changed the title Download extraction dev 4 Priority change between Download Location extraction and Scanner operation Aug 11, 2023
@JustinWonjaePark JustinWonjaePark changed the title Priority change between Download Location extraction and Scanner operation Priority change between Download Location extraction and scanner operation Aug 11, 2023
@JustinWonjaePark JustinWonjaePark force-pushed the download_extraction_dev_4 branch from efbb724 to 0189fe9 Compare August 18, 2023 04:07
@JustinWonjaePark JustinWonjaePark force-pushed the download_extraction_dev_4 branch from 0189fe9 to b89220f Compare August 18, 2023 04:15
soimkim
soimkim reviewed Aug 18, 2023
View reviewed changes
soimkim
soimkim reviewed Aug 18, 2023
View reviewed changes
soimkim
soimkim reviewed Aug 18, 2023
View reviewed changes
soimkim
soimkim reviewed Aug 18, 2023
View reviewed changes
@JustinWonjaePark
fix merging
c1f4e12 
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
@JustinWonjaePark JustinWonjaePark force-pushed the download_extraction_dev_4 branch from 2e6101c to c1f4e12 Compare August 21, 2023 04:12
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 21, 2023
@soimkim soimkim merged commit 1a446a5 into fosslight:main Aug 21, 2023
@JustinWonjaePark JustinWonjaePark deleted the download_extraction_dev_4 branch November 7, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soimkim soimkim soimkim left review comments

Assignees

@JustinWonjaePark JustinWonjaePark

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JustinWonjaePark @soimkim