Skip to content

Conversation

@JustinWonjaePark
Copy link
Contributor

Description

  • Create run_scanners so that FL Scanner can call via api
  • Make value of Exclude column for binary and .m4 files as "Exclude"
  • Remove deprecated code for correct mode

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark added the chore [PR/Issue] Refactoring, maintenance the code label Sep 8, 2023
@JustinWonjaePark JustinWonjaePark self-assigned this Sep 8, 2023
@JustinWonjaePark JustinWonjaePark marked this pull request as draft September 8, 2023 02:31
@JustinWonjaePark JustinWonjaePark requested review from dd-jy and removed request for soimkim September 8, 2023 04:08
@JustinWonjaePark JustinWonjaePark marked this pull request as ready for review September 8, 2023 04:08
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
Signed-off-by: Wonjae Park <wonjae.park@lge.com>
@JustinWonjaePark JustinWonjaePark merged commit 133ad4b into main Sep 12, 2023
@JustinWonjaePark JustinWonjaePark deleted the dev_create_run_scan branch September 14, 2023 08:26
def is_exclude_file(file_path, prev_dir=None, prev_dir_exclude_value=None):
file_path = file_path.lower()
filename = os.path.basename(file_path)
if os.path.splitext(filename)[1] in _exclude_extension:
Copy link
Contributor

@soimkim soimkim Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinWonjaePark , 파일 확장자 없는 파일 (ex. Makefile) 있으면 에러 발생할 것으로 보입니다. 확인 부탁드립니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants