Skip to content

Conversation

@soimkim
Copy link
Contributor

@soimkim soimkim commented May 15, 2021

Description

  • Return only the result when call it as a function.
  • Change log level by message.

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim requested review from bjk7119 and dd-jy May 15, 2021 02:55
@soimkim soimkim added the patch [PR version] Patch version up (ex, vA.B.C : C version up) label May 15, 2021
Copy link
Contributor

@dd-jy dd-jy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@bjk7119
Copy link
Contributor

bjk7119 commented May 17, 2021

Good

@soimkim soimkim merged commit 407a051 into main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch [PR version] Patch version up (ex, vA.B.C : C version up)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants