server: Consider 'unknown' to be an arbitrarily new version#42
Merged
swinslow merged 1 commit intofossology:masterfrom May 24, 2022
Merged
server: Consider 'unknown' to be an arbitrarily new version#42swinslow merged 1 commit intofossology:masterfrom
swinslow merged 1 commit intofossology:masterfrom
Conversation
Contributor
Author
|
This is really more of a workaround than a solution, but it seems better than nothing. (Testing it now.) |
Recent Docker container images from https://hub.docker.com/r/fossology/fossology show up as version 'unknown', which is not comparable. It seems like the best we can do here is to assume that 'unknown' means a modern version. Resolves: fossology#41 Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
force-pushed
the
treat-unknown-as-new-version
branch
from
912419d to
7482145
Compare
Contributor
|
Thanks @smcv! (And apologies for the long delay in circling back on this.) I think you're right, this seems like the best of the options for handling this unideal situation. I'm merging this now -- thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent Docker container images from
https://hub.docker.com/r/fossology/fossology show up as version
'unknown', which is not comparable. It seems like the best we can do
here is to assume that 'unknown' means a modern version.
Resolves: #41