Make logo path and button icon computed() properties#162
Merged
idlip merged 4 commits intofossunited:developfrom Nov 17, 2025
Merged
Make logo path and button icon computed() properties#162idlip merged 4 commits intofossunited:developfrom
computed() properties#162idlip merged 4 commits intofossunited:developfrom
Conversation
Collaborator
|
Just one nitpick, can we please have dark as preferred color... That is the color that defined forklore theme mostly, so yeah! LGTM, just dark as first choice ! |
Contributor
Author
|
Sure, that's fine with me! |
agriyakhetarpal
commented
Nov 17, 2025
Suggested-by: Dilip <igoldlip@gmail.com>
Collaborator
|
Okay, after looking at site I still saw svg issue. So explored docs here: https://color-mode.nuxtjs.org/advanced/migration#_3-read-only-color-mode-value So I'm setting preference to system and fallback to dark Should be fixed and good to go. Thank you for bringing this up to attention, thanks to that I also read up to understand how it worked. |
Contributor
Author
|
Oops, thanks for the catch! |
idlip
added a commit
to idlip/forklore
that referenced
this pull request
Nov 17, 2025
- complements thanks to fossunited#162 - doc: https://color-mode.nuxtjs.org/advanced/migration#_3-read-only-color-mode-value - value is read only meant to be used for code, but we can simply use preference to adjust changes - set preference to system (default in nuxt) and fallback to dark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #161 and renders
logos/logo_dark.svgon the initial load of the website in light mode, so that it uses the black-text logo instead of the sage green one (which is intended for dark mode)..instead of the moon iconI do not usually work with Vue.js; please verify if this is the correct approach before merging. Thank you!
Noting this here, in case it helps any other maintainers in the future: I ran into nuxt-modules/color-mode#262 for a bit, and the idea is to always load the page with caches disabled; otherwise,
localStorageinterferes with the preference value.