called the wrong method - $this->getState() is the right one#2
Merged
cdot merged 1 commit intofoswiki:masterfrom Mar 12, 2015
Merged
called the wrong method - $this->getState() is the right one#2cdot merged 1 commit intofoswiki:masterfrom
cdot merged 1 commit intofoswiki:masterfrom
Conversation
Contributor
|
On 12/03/15 07:34, Markus Gerhold wrote:
BTW I was debating whether we should make the 'not' expression more C. |
cdot
added a commit
that referenced
this pull request
Mar 12, 2015
called the wrong method - $this->getState() is the right one
Contributor
Author
|
Sure, for one, we could add the case where the LASTUSER of a state is actually allowed to do something. Currently we can only negate the LASTUSER. What scenarios do you have in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, that slipped through my tests
Cheers, Markus