fix: space missing from data_formatter_template causing mismatch with response_template #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarikrishnanBalagopal
requested review from
Ssukriti,
aluu317,
anhuong,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
HarikrishnanBalagopal
force-pushed
the
fix/docs
branch
from
d79116a to
a06d9e2
Compare
… response_template Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
HarikrishnanBalagopal
force-pushed
the
fix/docs
branch
from
a06d9e2 to
8807dde
Compare
Collaborator
|
@Abhishek-TAMU @willmj if you are okay with this fix please merge... @HarikrishnanBalagopal noticed this while debugging for an internal use case with @prince14322 that space was missing from the doc. |
Abhishek-TAMU
approved these changes
Feb 5, 2025
Collaborator
Abhishek-TAMU
left a comment
Abhishek-TAMU
left a comment
There was a problem hiding this comment.
Yea if response template is \n## Label: then this fix in data_formatter_template makes sense. Thank you for catching this. LGTM!
willmj
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Related issue number
How to verify the PR
Was the PR tested