Skip to content

Attributes for inner link in button and menu-item#94

Closed
AliakseiT wants to merge 4 commits intofoundation:developfrom
AliakseiT:href-attributes-support
Closed

Attributes for inner link in button and menu-item#94
AliakseiT wants to merge 4 commits intofoundation:developfrom
AliakseiT:href-attributes-support

Conversation

@AliakseiT
Copy link
Copy Markdown

To enable attributes directly on inner <a href=""></a> of button and menu-item we can transfer parent's element attributes that start with href-. E.g. <button href-clicktracking="off" href="https://my.domain.com">...</button>
after processing will contain ...<a clicktracking="off" href="https://my.domain.com">...</a>...

This enables usage of custom attributes like Sendgrid's clicktracking="off".

@joeworkman
Copy link
Copy Markdown
Member

Closing — attribute passthrough is being redesigned in v2 with proper support for custom attributes on all components (addresses #48 and #111). Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants