lmp/build.sh: Make sure to fetch the tags#411
lmp/build.sh: Make sure to fetch the tags#411ricardosalveti merged 2 commits intofoundriesio:masterfrom
Conversation
Fetch tags from GH_TARGET_REPO into the local clone before handing it off to repo init, so the tags are available in the setup-environment-internal context. Fix the error on scarthgap: Saved manifest to /archive/manifest.pinned.xml == 2026-04-07 20:47:38 Base LmP cache version detected as: 97 fatal: No names found, cannot describe anything. Script completed with error(s) == 2026-04-07 20:47:42.780281: Finding artifacts to upload Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
|
when testing on debug-branch, it worked for scarthgap: https://ci.foundries.io/projects/lmp/builds/2963/ for a history of the debug: FFTK-4758 |
We don't need to debug anymore, so go back on using master. This reverts commit 7dc72a5. Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
doanac
left a comment
There was a problem hiding this comment.
LGTM and should be safe for normal factory builds
quaresmajose
left a comment
There was a problem hiding this comment.
I'd like to understand why this problem only started happening now, when we've had the branch for quite some time. And also why this doesn't happen on the master branch. It would be helpful to include this in the commit message.
|
@quaresmajose I don't know. It's been bugging me why now, but the fact is that I don't know. Do you have ideas on what to look at/research to understand this? 2 things happened:
For the first, I have tried to find evidences that creating the github release would impact a git command, but I could find anything. For me, they are not related at all (however, if you know anything else, let me know. I've been using For the second, git version? what else? |
It doesn't seem plausible to me that it's due to that, but it's not impossible. I think a revert of that change 9b05ca6 would clarify that possibility. |
yeah, it is an interesting one, something changed in our tooling, probably due next indeed. |
|
I reverted the commit to fetch the tags, and the one changing the lmp-sdk and could reproduce the same error. So, I think this is not related (as expected) |
Fetch tags from GH_TARGET_REPO into the local clone before handing it off to repo init, so the tags are available in the setup-environment-internal context.
Fix the error on scarthgap: