fix(winpe): provision USB partitions with storage cmdlets#166
Merged
Conversation
github-actions
Bot
added
tests
mchave3
force-pushed
the
fix/usb-boot-image-provisioning
branch
from
9ac2b64 to
de02668
Compare
mchave3
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
mchave3
force-pushed
the
fix/usb-boot-image-provisioning
branch
from
de02668 to
c1fcc9f
Compare
mchave3
force-pushed
the
fix/usb-boot-image-provisioning
branch
from
c1fcc9f to
20a25e4
Compare
github-actions
Bot
added
ui
| new WinPeBuildArtifact | ||
| { | ||
| WorkingDirectoryPath = workspace.RootPath, | ||
| MediaDirectoryPath = Path.Combine(workspace.RootPath, "media"), |
| new WinPeBuildArtifact | ||
| { | ||
| WorkingDirectoryPath = workspace.RootPath, | ||
| MediaDirectoryPath = Path.Combine(workspace.RootPath, "media"), |
mchave3
force-pushed
the
fix/usb-boot-image-provisioning
branch
from
20a25e4 to
f38c4d9
Compare
mchave3
force-pushed
the
fix/usb-boot-image-provisioning
branch
from
f38c4d9 to
a26a1d6
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a USB media creation failure (#165) caused by DiskPart losing volume focus between select volume and format. The provisioning step now invokes a PowerShell Storage cmdlet script (passed as an -EncodedCommand) that clears, initializes, partitions, and formats the BOOT and cache volumes by explicit drive letter. The script emits Foundry-prefixed progress/verbose markers that the service forwards through the existing IProgress<WinPeMediaProgress> pipeline (extended with a new LogDetail field), and adds localized substep strings (en-US, fr-FR) plus regression tests.
Changes:
- Replace DiskPart-based
BuildDiskPartScriptwithBuildPowerShellProvisioningScript, executed viaIWinPeProcessOutputRunnerso progress/verbose markers can be streamed to the UI. - Extend
WinPeMediaProgresswithLogDetailand surface it inStartMediaViewModellogging and new localized status strings. - Update unit tests to cover the new script generation, output forwarding, and confirm DiskPart is no longer invoked.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Foundry.Core/Services/WinPe/WinPeUsbMediaService.cs | Switch USB partition/format to PowerShell Storage cmdlets, stream progress/verbose markers, update failure diagnostics. |
| src/Foundry.Core/Services/WinPe/WinPeMediaProgress.cs | Add LogDetail property for forwarded verbose diagnostics. |
| src/Foundry/ViewModels/StartMediaViewModel.cs | Log LogDetail and map new provisioning substep statuses to resource keys. |
| src/Foundry/Strings/en-US/Resources.resw | Add English strings for the new USB provisioning substeps. |
| src/Foundry/Strings/fr-FR/Resources.resw | Add French translations for the new USB provisioning substeps. |
| src/Foundry.Core.Tests/WinPe/WinPeUsbMediaServiceTests.cs | Replace DiskPart-script tests with PowerShell-script tests; add streaming/output forwarding regression coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+368
to
+370
| "Clear-Disk -Number $diskNumber -RemoveData -RemoveOEM -Confirm:$false -ErrorAction Stop", | ||
| "Update-HostStorageCache -ErrorAction SilentlyContinue", | ||
| "Write-FoundryUsbVerbose 'USB partition table cleared and host storage cache refreshed.'", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix USB boot media provisioning by replacing the DiskPart partitioning script with PowerShell Storage cmdlets and restoring detailed provisioning diagnostics in the media logs.
Fixes #165.
Reason
DiskPart can create a partition without reliably keeping a usable volume selected on fresh or inconsistent removable media. The original issue failed after
select volume=<letter>, and the later USB test showed the same class of failure whenformatran without an explicitly selected volume.Using Storage cmdlets lets Foundry create partitions with explicit drive letters and format those volumes directly by drive letter, without depending on DiskPart focus state. The Storage cmdlets are quiet on success, so the script emits Foundry progress markers plus clean provisioning diagnostics that are streamed back into
Foundry.logthrough the existing media progress pipeline. Native PowerShell verbose/progress streams are not forwarded because Windows PowerShell 5.1 serializes them as CLIXML in redirected streams.Main changes
diskpart.exewith an encoded PowerShell Storage script.LogDetail, while keeping the visible operation status readable.Testing notes
diskpart.exe.dotnet test src\Foundry.Core.Tests\Foundry.Core.Tests.csproj --filter "FullyQualifiedName~WinPeUsbMediaServiceTests" --logger "console;verbosity=normal": 23 passed.dotnet build src\Foundry\Foundry.csproj --no-restore: succeeded, 0 warnings, 0 errors.dotnet test src\Foundry.Core.Tests\Foundry.Core.Tests.csproj --logger "console;verbosity=normal": 178 passed.git diff --check: clean, with Windows line-ending warnings only.