chore: update to rust edition 2024, rust-version 1.93, and add workspace lint rules#160
Merged
zerosnacks merged 3 commits intofoundry-rs:zerosnacks/bump-rust-versionfrom Apr 1, 2026
Conversation
- Update workspace edition from 2021 to 2024 - Update rust-version from 1.76 to 1.93 - Update resolver from 2 to 3 - Update clippy.toml MSRV - Update CI workflow and README MSRV references - Fix edition 2024 issues: - Remove explicit `ref` in match pattern (implicit borrowing) - Wrap `env::set_var` in unsafe blocks (now unsafe in edition 2024) - Reformat imports per edition 2024 rustfmt style Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
- Add workspace.lints.clippy, workspace.lints.rust, workspace.lints.rustdoc matching foundry-rs/foundry configuration - Add [lints] workspace = true to both crates - Update clippy.toml with ignore-interior-mutability - Fix all lint violations (use-self, uninlined-format-args, redundant-clone, redundant-imports) Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
decofe
changed the title
mattsse
approved these changes
Apr 1, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense
@zerosnacks I believe those failing tests are just flaky
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Merging in staging branch and re-opening under my name to be sure the tests are simply flaky |
zerosnacks
merged commit d35901c
into
foundry-rs:zerosnacks/bump-rust-version
9 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update workspace to Rust edition 2024 / MSRV 1.93 and add workspace lint rules matching
foundry-rs/foundry.Changes
edition: 2021 → 2024rust-version: 1.76 → 1.93resolver: 2 → 3clippy.tomlMSRV: 1.76 → 1.93, addignore-interior-mutability[workspace.lints.clippy],[workspace.lints.rust],[workspace.lints.rustdoc]matchingfoundry-rs/foundry[lints] workspace = trueto both cratesEdition 2024 fixes
refin match pattern (block_number.rs)env::set_varinunsafeblocks (account.rstests) — now unsafe in edition 2024Lint fixes
use-self: replaced type names withSelfin impl blocksuninlined-format-args: inlined format argumentsredundant-clone: removed unnecessary.clone()redundant-imports: removedFutureimport (now in edition 2024 prelude)Prompted by: zerosnacks