This repository was archived by the owner on Apr 20, 2026. It is now read-only.
chore: update to rust edition 2024, bump MSRV to 1.93#364
Merged
zerosnacks merged 12 commits intofoundry-rs:mainfrom Apr 13, 2026
Merged
chore: update to rust edition 2024, bump MSRV to 1.93#364zerosnacks merged 12 commits intofoundry-rs:mainfrom
zerosnacks merged 12 commits intofoundry-rs:mainfrom
Conversation
- Update workspace edition from 2021 to 2024, resolver from 2 to 3 - Rename `gen` variables to `generator` (reserved keyword in 2024) - Collapse nested if-let chains (clippy::collapsible_if with let-chains) - Wrap `env::set_var`/`remove_var` in unsafe blocks (unsafe in 2024) - Fix doctest to avoid unsafe env mutation - Apply rustfmt import reordering (edition 2024 style) Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
Fixes svm-rs-builds duplicate SOLC_VERSION_0_8_31 const bug in v0.5.17. Also fixes remaining --all-features lint violations. Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4875-5cb2-777c-9a8f-e4d7b6c4ccfa
decofe
changed the title
zerosnacks
reviewed
Apr 2, 2026
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d7736-f2b4-75e7-b717-8ac61d305b43
The upstream clippy bug (rust-lang/rust-clippy#13885) was fixed in rust-lang/rust-clippy#13953 (merged Feb 2025). The workaround is no longer needed. Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
zerosnacks
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
editionfrom2021to2024andresolverfrom2to31.88to1.93clippy.tomlMSRV to1.93foundry-rs/foundrygenvariables togenerator(genis a reserved keyword in edition 2024)if/if letinto let-chains (clippy::collapsible_if)env::set_var/remove_varin unsafe blocks (unsafe in edition 2024)rustfmtimport reordering (edition 2024 style).iter()→&,.cloned()→.copied()The MSRV bump to 1.93 also unblocks
svm-rs/svm-rs-buildsresolving to0.5.24(previously capped at0.5.17by MSRV 1.88), which fixes a duplicateSOLC_VERSION_0_8_31const bug in generated code.Prompted by: zerosnacks