Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

fix: account for unicode width in error syntax highlighting#40

Merged
DaniPopes merged 3 commits intomainfrom
dani/fix-error-fmt
Jan 6, 2024
Merged

fix: account for unicode width in error syntax highlighting#40
DaniPopes merged 3 commits intomainfrom
dani/fix-error-fmt

Conversation

@DaniPopes
Copy link
Copy Markdown
Member

No description provided.

Comment thread src/artifacts/mod.rs

pub mod error;
#[allow(ambiguous_glob_reexports)]
pub use error::*;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 3 different SourceUnit in this module.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I was only able to find

struct SourceUnit {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, SourceLocation

@DaniPopes DaniPopes marked this pull request as ready for review January 6, 2024 12:21
@DaniPopes DaniPopes requested a review from Evalir as a code owner January 6, 2024 12:21
@DaniPopes DaniPopes requested a review from mattsse January 6, 2024 12:21
@DaniPopes DaniPopes merged commit 952bf64 into main Jan 6, 2024
@DaniPopes DaniPopes deleted the dani/fix-error-fmt branch January 6, 2024 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants