fix: make vm.py compatible with Python 3.9 (stock macOS)#852
Merged
zerosnacks merged 3 commits intomasterfrom Apr 23, 2026
Merged
fix: make vm.py compatible with Python 3.9 (stock macOS)#852zerosnacks merged 3 commits intomasterfrom
zerosnacks merged 3 commits intomasterfrom
Conversation
Replace Python 3.10+ union type syntax (int | str, X | None) with typing.Union and typing.Optional for compatibility with the stock macOS Python 3.9.6. Also regenerated src/Vm.sol via vm.py. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019db99b-87a5-7768-9a12-803d0db1baa2
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/vm.pyuses Python 3.10+ union type syntax (int | str,X | None) which fails on macOS stock Python 3.9.6:Fix
int | strwithUnion[int, str]andCheatcodes | NonewithOptional[Cheatcodes]UnionandOptionalfromtypingsrc/Vm.solviavm.pytest/Vm.t.sol