chore: bump revm 31 #12461
Merged
chore: bump revm 31 #12461
+372
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
matt/bump-revm31
branch
from
897d9af to
9126c24
Compare
onbjerg
force-pushed
the
matt/bump-revm31
branch
from
9126c24 to
d7f486c
Compare
3 tasks
mattsse
commented
Nov 5, 2025
Comment on lines
+93
to
+96
| // Transfer the value between accounts | ||
| internals | ||
| .transfer(from_address, to_address, value) | ||
| .map_err(|e| PrecompileError::Other(format!("Failed to perform transfer: {e:?}")))?; |
There was a problem hiding this comment.
The inner journal impl makes the same balance checks as above but the errors are not bubbled up, this may be a nice follow-up.
https://github.com/bluealloy/revm/blob/a1fdb9d9e98f9dd14b7577edbad49c139ab53b16/crates/context/src/journal/inner.rs#L315-L320
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy and
onbjerg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this still needs some work
with recent revm change we can no longer access &mut Account and need workarounds for this
ideally helpers on
EvmInternalstodo
figure out which ones and upstream to alloy-evm and make nicer