Skip to content

Collapse redundant Windows pipe path check in provider #12628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Collapse redundant Windows pipe path check in provider #12628

wants to merge 1 commit into from
+4 −4

Conversation

@Doryu001
Copy link

@Doryu001 Doryu001 commented Nov 21, 2025

merge the nested if let/if in resolve_path into a single condition, keep the Windows named-pipe fast path while removing the clippy::collapsible_if warning

@Doryu001
Copy link
Author

Doryu001 commented Nov 26, 2025

we can do migrate

@onbjerg onbjerg added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
DaniPopes added a commit that referenced this pull request Nov 27, 2025
@DaniPopes
chore: aggregate PRs
a867af7 
This PR aggregates changes from the following PRs:

- Closes #12628 by @\Doryu001
- Closes #12648 by @\ANtutov
- Closes #12656 by @\Bilogweb3
@DaniPopes DaniPopes mentioned this pull request Nov 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2025
@DaniPopes
chore: aggregate PRs (#12669)
c370ba2 
This PR aggregates changes from the following PRs:

- Closes #12628 by @\Doryu001
- Closes #12648 by @\ANtutov
- Closes #12656 by @\Bilogweb3
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Doryu001 @onbjerg