Skip to content

chore: cast erc20 to follow cast send options #12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2025
Merged

chore: cast erc20 to follow cast send options #12684

merged 2 commits into from
Nov 28, 2025
+157 −126

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 28, 2025 •
edited
Loading

Motivation

  • add same options for cast erc20 state changing commands as for cast send (async, confirmation, timeout, poll interval)
  • reuse cast_send for erc20 calls, wait and display for receipt or tx only if async

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review November 28, 2025 14:49
zerosnacks
zerosnacks approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@grandizzy grandizzy added this pull request to the merge queue Nov 28, 2025
Merged via the queue into master with commit c4e4b4e Nov 28, 2025
15 checks passed
@grandizzy grandizzy deleted the gdzzy/chore-cast-erc20 branch November 28, 2025 15:35
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grandizzy @zerosnacks