fix: add log fn support alongside log_full fn, follow-up fix for revm 33
#12718
+78
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
0xrusowsky
approved these changes
Dec 4, 2025
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
i think it makes sense
| // Fail immediately | ||
| interpreter.bytecode.set_action(InterpreterAction::new_return( | ||
| InstructionResult::Revert, | ||
| Error::encode("log emitted but expected 0 times"), |
Contributor
There was a problem hiding this comment.
optional nit: log emitted but not expected or smth like this?
Member
There was a problem hiding this comment.
msg shouldnt change here just keep it the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should be implementing
logalongsidelog_fullnot either. This allows forvm.expectEmitto work against logs in cases where the interpreter is not available.