refactor(anvil-core): make ImpersonatedTransaction and BlockInfo generic#13629
Merged
DaniPopes merged 2 commits intofoundry-rs:masterfrom Mar 6, 2026
Merged
refactor(anvil-core): make ImpersonatedTransaction and BlockInfo generic#13629DaniPopes merged 2 commits intofoundry-rs:masterfrom
DaniPopes merged 2 commits intofoundry-rs:masterfrom
Conversation
mablr
suggested changes
Mar 5, 2026
DaniPopes
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Preparation for phasing out
FoundryNetworkby making anvil-core RPC types generic overNetwork. CurrentlyMaybeImpersonatedTransactionandBlockInfoare hardcoded toFoundryTxEnvelopeandFoundryReceiptEnvelope, preventing reuse with different network implementations.Solution
1. Remove
into_rpc_transactionfromanvil-coreinto_rpc_transaction()andFrom<MaybeImpersonatedTransaction> for RpcTransactionfrom anvil-coretransaction_build()inanvil/src/eth/backend/mem/mod.rswhere it belongs (anvil-level concern, not a core type concern)2. Extract
ImpersonatedTxEnvelopetraittx_hash(),recover_signer(),impersonated_hash()— the interfaceMaybeImpersonatedTransactionneeds from its inner envelopeFoundryTxEnvelope, decoupling anvil-core from the concrete type3. Make
ImpersonatedTransaction<T>genericImpersonatedTransaction<T>with all trait impls (Typed2718,Encodable2718,Encodable,Decodable,AsRef,Deref) generic overTMaybeImpersonatedTransaction = ImpersonatedTransaction<FoundryTxEnvelope>preserves backward compat — zero changes needed in downstream code4. Make
TypedBlockInfo<T, R>genericTypedBlockInfo<T, R>, generic over transaction and receipt typesBlockInfo = TypedBlockInfo<MaybeImpersonatedTransaction, FoundryReceiptEnvelope>preserves backward compatcreate_typed_block<T>generic helper alongside existingcreate_blockPR Checklist