refactor(anvil): remove some intermediate Env wrappers, pass EvmEnv directly#13941
Merged
zerosnacks merged 1 commit intofoundry-rs:masterfrom Mar 26, 2026
Merged
Conversation
…rectly Replace usage of the `Env` struct wrapper with direct `EvmEnv` references in `new_eth_evm_with_inspector`, `validate_pool_transaction_for`, and `validate_for`. The optimism flag is now passed explicitly as `is_optimism: bool` instead of being extracted from `env.networks`. This eliminates unnecessary `Env::new(...)` construction in several hot paths (block mining, pending block simulation, tx replay) and simplifies the function signatures.
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Mar 26, 2026
mablr
commented
Mar 26, 2026
Contributor
Author
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
Of course, all of these will be just dropped asap with BlockExecutorFactory introduction.
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replace usage of the
Envstruct wrapper with directEvmEnvreferences innew_eth_evm_with_inspector,validate_pool_transaction_for, andvalidate_for. The optimism flag is now passed explicitly asis_optimism: boolinstead of being extracted fromenv.networks. This eliminates unnecessaryEnv::new(...)construction in several hot paths (block mining, pending block simulation, tx replay) and simplifies the function signatures.