Open
Conversation
mablr
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
mablr
force-pushed
the
mablr/partial_tempo_ci_upstream
branch
from
bf6efbd to
3c35e5b
Compare
mablr
force-pushed
the
mablr/partial_tempo_ci_upstream
branch
from
3c35e5b to
12708b9
Compare
mablr
commented
Apr 9, 2026
zerosnacks
reviewed
Apr 9, 2026
Member
|
I have added |
zerosnacks
reviewed
Apr 9, 2026
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
zerosnacks
reviewed
Apr 9, 2026
zerosnacks
reviewed
Apr 9, 2026
3 tasks
figtracer
added a commit
to figtracer/foundry
that referenced
this pull request
Apr 10, 2026
keychain.rs: - Use T3 authorizeKey(address,uint8,KeyRestrictions) selector (TIP-1011) - Add period field to ExtTokenLimit - Fix --scopes clap panic with ScopesJson newtype - Add TIP-20 selector shorthands (transfer, approve, etc.) - Reject unknown bare selector names with clear error - Fix revoke display (check isRevoked before !provisioned) tempo-check.sh (vs mablr's foundry-rs#14206): - Uncomment access key + all 29 keychain tests - ${FEE_TOKEN} bracing before : to prevent zsh modifier expansion - grep "revoked" instead of "true" for revoke verification
mablr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Upstream Tempo CI
As some tests are still falling, I commented the problematic sections with
# TODO(upstream)marker describing the reason. This will help to iterate faster towards full Tempo upstream.The only change applied to test scripts is replacing
grep -oPwithsed -ncounterpart for better compatibility over all *nix OS flavors.