feat(lint): redundant-base-constructor-call#14634
Merged
Merged
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
zerosnacks
as code owners
mablr
reviewed
May 7, 2026
p5hzehxa
approved these changes
May 7, 2026
p5hzehxa
approved these changes
May 7, 2026
…nt-base-ctor Amp-Thread-ID: https://ampcode.com/threads/T-019e17e2-73a9-75ef-af33-ed3b4770b591 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # crates/lint/README.md # crates/lint/src/sol/info/mod.rs
…nt-base-ctor Amp-Thread-ID: https://ampcode.com/threads/T-019e21be-c271-73ad-a533-b570bbe49627 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # crates/lint/src/sol/info/mod.rs
zerosnacks
reviewed
May 13, 2026
zerosnacks
approved these changes
May 13, 2026
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
lgtm 👍 , applied a minor doc fix in 139e4df
figtracer
approved these changes
May 13, 2026
mablr
approved these changes
May 13, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Info lint,
redundant-base-constructor-call, that flags explicit empty base-constructor specifiers (is A()orconstructor() A() {}) when the base contract either has no constructor or a zero-parameter constructor.