fix(evm-core): wait for pending_tasks before completing MultiForkHandler#14728
Open
AissataF wants to merge 1 commit into
Open
fix(evm-core): wait for pending_tasks before completing MultiForkHandler#14728AissataF wants to merge 1 commit into
pending_tasks before completing MultiForkHandler#14728AissataF wants to merge 1 commit into
Conversation
…andler` `MultiForkHandler::poll` returned `Poll::Ready(())` as soon as `handlers` was empty and `incoming` was closed, even when `pending_tasks` still held in-flight `ForkTask::Create` futures. Those tasks register their handler only after they resolve, so an early exit dropped them and left the requesting `sender` waiting forever. Added `pending_tasks.is_empty()` to the exit condition so the future stays alive until every queued fork creation has settled.
AissataF
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiForkHandler::pollreturnedPoll::Ready(())as soon ashandlerswas empty andincomingwas closed, even whenpending_tasksstill held in-flightForkTask::Createfutures. Those tasks register their handler only after they resolve, so an early exit dropped them and left the requestingsenderwaiting forever. Addedpending_tasks.is_empty()to the exit condition so the future stays alive until every queued fork creation has settled.