feat(lint): add event-fields lint#14751
Open
stevencartavia wants to merge 3 commits into
Open
Conversation
stevencartavia
requested review from
DaniPopes,
grandizzy,
mattsse and
zerosnacks
as code owners
stevencartavia
requested review from
0xrusowsky,
figtracer and
mablr
as code owners
mattsse
previously approved these changes
May 14, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
Code changes look good to me. The failing docs-link check appears flaky/external to this patch.
Collaborator
@mattsse merging foundry-rs/book#1842 will resolve the error. |
figtracer
reviewed
May 15, 2026
| fn is_filterable_field(param: &VariableDefinition<'_>) -> bool { | ||
| let TypeKind::Elementary(elem) = ¶m.ty.kind else { return false }; | ||
| match elem { | ||
| ElementaryType::Address(_) => true, |
Collaborator
There was a problem hiding this comment.
this kind of name-based heuristic tends to annoy users
Collaborator
Author
There was a problem hiding this comment.
the match is suffix-based and case-sensitive. Do you have a concrete false-positive in mind?
figtracer
reviewed
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
event-fields, info lint that flags unindexedaddress,address payable, and id-likeuint256/bytes32event parameters.