fix(verify): warn and fall back to Sourcify when ETHERSCAN_API_KEY is set on unsupported chain#14765
Open
mablr wants to merge 4 commits into
Open
fix(verify): warn and fall back to Sourcify when ETHERSCAN_API_KEY is set on unsupported chain#14765mablr wants to merge 4 commits into
ETHERSCAN_API_KEY is set on unsupported chain#14765mablr wants to merge 4 commits into
Conversation
set on unsupported chain Co-authored-by: Amp <amp@ampcode.com>
mablr
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mattsse,
stevencartavia and
zerosnacks
as code owners
figtracer
reviewed
May 14, 2026
figtracer
reviewed
May 14, 2026
figtracer
approved these changes
May 14, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #10774
When the user does not pass
--verifierbutETHERSCAN_API_KEYis set, we defaulted to Etherscan for any chain, including chains with no known Etherscan API URL, which would then fail at verification time. Now we fall back to Sourcify.PR Checklist