fix: remove forge init template history #4001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Dec 31, 2022
cli/src/cmd/forge/init.rs
Outdated
| .output()? | ||
| .stdout; | ||
| let commit_hash = String::from_utf8(git_output)?; | ||
| Command::new("rm").args(["-rf", ".git"]).exec()?; |
Member
There was a problem hiding this comment.
Suggested change
| Command::new("rm").args(["-rf", ".git"]).exec()?; | |
| std::fs::remove_dir_all(".git")?; |
| Command::new("git") | ||
| .args(["clone", "--recursive", &template, &root.display().to_string()]) | ||
| .exec()?; | ||
|
|
Member
There was a problem hiding this comment.
don't we also have to "cd" into it (std::env::set_current_dir)?
Collaborator
Author
There was a problem hiding this comment.
ah yes it seems root can be set and is not always the current dir, will fix
foundry/cli/src/cmd/forge/init.rs
Line 66 in 7518d37
Member
There was a problem hiding this comment.
I think that .current_dir on the clone command was fine, i meant that when we're deleting the .git folder and initializing, we have to move into in the newly cloned repo directory
sorry didn't see the last reply, ty
DaniPopes
approved these changes
Dec 31, 2022
mattsse
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you
forge init --template <TEMPLATE>it's just an alias togit clonethe template. This means your new forge project is initialized with the template's commit history and the template repo set as the remote.OTOH, when you click the "Use this template" button in the github UI it creates a repo with a single commit from the person who forked it with the message "Initial commit". This behavior is preferable as you don't want the template's commits and authors in your repo history, nor do you want it a a remote.
This PR updates
forge init --template <TEMPLATE>to behave similarly by deleting the git folder and initializing a new repo