Skip to content

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 17, 2023

Motivation

Before: bad. After: slightly better.

Solution

  • cli/{forge,cast} -> forge/bin,cast/bin
  • cli/test-utils -> ../
  • Remove forge and cast as dependencies in other crates. They should not be used as dependencies.
  • split off cast tests from cli/tests, rest went into forge/tests/cli

@DaniPopes DaniPopes changed the title chore: move forge and cast to their own crates chore: move forge and cast binaries to their own crates Aug 17, 2023
@Evalir Evalir requested review from Evalir and mattsse August 17, 2023 15:03
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive, can merge once compiles

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as matt—once ci is green and some smol testing is done i think we should be good to go

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg, awesome

@mattsse mattsse merged commit 236208f into foundry-rs:master Aug 17, 2023
@DaniPopes DaniPopes deleted the bins branch August 17, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants