Skip to content

chore: move forge and cast binaries to their own crates #5652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 17, 2023
Merged

chore: move forge and cast binaries to their own crates #5652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3e523c6
move out
DaniPopes Aug 15, 2023
fe56a46
wip moving tests
DaniPopes Aug 15, 2023
c3a242b
back to crates
DaniPopes Aug 17, 2023
281abf6
fixes
DaniPopes Aug 17, 2023
84f855a
unused deps and fix tests
DaniPopes Aug 17, 2023
336138f
Merge branch 'master' into bins
DaniPopes Aug 17, 2023
2f53a09
fix ci
DaniPopes Aug 17, 2023
876193f
fixes
DaniPopes Aug 17, 2023
44b0b9c
update foundryup
DaniPopes Aug 17, 2023
5e1b446
features
DaniPopes Aug 17, 2023
653142a
fixtest
DaniPopes Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cross-platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:
if: matrix.nextest.name != 'non-forking'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}
- name: Setup git config
run: |
git config --global user.name "GitHub Actions Bot"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deny.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ jobs:
with:
command: check all
# Clear out arguments to not pass `--all-features` to `cargo deny`.
# `foundry-cli` has an `openssl` feature which enables banned dependencies
# many crates have an `openssl` feature which enables banned dependencies
arguments: ""
6 changes: 3 additions & 3 deletions .github/workflows/heavy-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
archive:
- name: heavy-integration-tests
file: heavy-integration.tar.zst
flags: -p foundry-cli --features heavy-integration-tests
flags: -p forge --features heavy-integration-tests
steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@stable
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
if: matrix.job.name != 'non-forking'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}

- name: Setup git config
run: |
Expand All @@ -100,4 +100,4 @@ jobs:
WORKFLOW_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
with:
update_existing: true
filename: .github/INTEGRATION_FAILURE.md
filename: .github/INTEGRATION_FAILURE.md
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
flags: --workspace
- name: external-integration-tests
file: nextest-external-integration.tar.zst
flags: -p foundry-cli --features external-integration-tests
flags: -p forge --features external-integration-tests
steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@stable
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
if: matrix.job.name != 'issue-repros'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}
- name: Setup git config
run: |
git config --global user.name "GitHub Actions Bot"
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
if: matrix.job.name != 'forge-std-test'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}
- name: Setup git config
run: |
git config --global user.name "GitHub Actions Bot"
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
if: matrix.job.name != 'non-forking'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}
- name: Setup git config
run: |
git config --global user.name "GitHub Actions Bot"
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
if: matrix.job.name != 'non-forking'
with:
path: "$HOME/.foundry/cache"
key: rpc-cache-${{ hashFiles('cli/tests/rpc-cache-keyfile') }}
key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }}

- name: Setup git config
run: |
Expand Down
Loading