Optimism Hardfork Support #8749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xForerunner
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
Member
|
Thanks @ewoolsey! Approach looks good to me, pending reviews of others |
zerosnacks
approved these changes
Aug 27, 2024
klkvr
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow specifying hardfork when running with optimism
Resolves #8732
Solution
Create new enums for optimism hardforks. Parsing is done when converting to config because clap does not support flag dependent value parsers unfortunately (at least as far as I know, If there's a good way to do this I'd love to know)